Move slot size recording into global heartbeat workflow #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
record-slot-size-in-heartbeat-flow
branch
from
d9c4871 to
e4a0bbf
Compare
|
@serprex can we also move connection related alerts to be here? |
Sure, that could be a followup PR |
Some misc improvements: 1. sleep in workflow, not activity 2. HandleSlotSize no longer needs to be threadsafe
serprex
force-pushed
the
record-slot-size-in-heartbeat-flow
branch
from
018bfb5 to
4ac0ef6
Compare
serprex
force-pushed
the
record-slot-size-in-heartbeat-flow
branch
from
89e2008 to
4601965
Compare
iskakaushik
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some misc improvements: